Skip to content

Conversation

@mabrarov
Copy link

Implementation of Upstream feature for the Elasticsearch output plugin.

Refer to fluent/fluent-bit#7608 for the changes in Fluent Bit code.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 24, 2023
@mabrarov
Copy link
Author

This pull request is waiting for review of fluent/fluent-bit#7608

@github-actions github-actions bot removed the Stale label Sep 25, 2023
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 24, 2023
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 7611f0e to 25c7642 Compare December 24, 2023 09:14
@github-actions github-actions bot removed the Stale label Dec 25, 2023
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 25c7642 to 7138a28 Compare February 24, 2024 11:09
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 7138a28 to c1092dc Compare August 29, 2024 07:21
@mabrarov mabrarov requested review from a team as code owners August 29, 2024 07:21
Copy link
Contributor

@cnorris-cs cnorris-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left suggestions, but I've added my technical writing-based approval based on that to keep this moving.

Primarily, I was looking to help the table be more consistent and readable, while implementing some style-based suggestions for consistency.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 2 times, most recently from a78ebf2 to c620db5 Compare August 29, 2024 13:51
@mabrarov
Copy link
Author

Hi @cnorris-cs,

I applied some (!) parts of your suggestions as well as introduced additional changes for consistency with your suggestions. Please take a look at this pull request one more time when you have time. Some of the changes are implemented in dedicated commits (for ease of revert in case of concerns) - please let me know if I need to squash all commits into a single one.

Thank you for your review.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from c620db5 to 23f04ef Compare October 13, 2024 15:28
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 23f04ef to d8bad1b Compare October 25, 2024 04:02
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from d8bad1b to d465436 Compare November 10, 2024 19:25
@esmerel
Copy link
Contributor

esmerel commented Jun 23, 2025

This still looks ok to me from a writing perspective.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 8ed632e to af68253 Compare July 6, 2025 12:51
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 3 times, most recently from c02d041 to 312b9a1 Compare July 21, 2025 20:50
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 312b9a1 to 02dbd5d Compare July 27, 2025 14:38
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor stylistic suggestions for consistency, but these docs changes look good to me otherwise.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 02dbd5d to da614db Compare August 2, 2025 19:48
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 2 times, most recently from dee1a67 to 6379bf2 Compare August 22, 2025 23:30
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 6379bf2 to dd6d5da Compare August 28, 2025 21:55
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from dd6d5da to a458946 Compare October 9, 2025 16:19
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 2 times, most recently from 9d9fc20 to e38893e Compare October 21, 2025 19:52
@eschabell eschabell self-assigned this Oct 22, 2025
@eschabell
Copy link
Collaborator

@esmerel can you look at the Vale check failures, I'm seeing this error before:

Raw Output:
{"message": "[FluentBit.Headings] 'Classic mode Configuration File with Upstream' should use sentence-style capitalization.", "location": {"path": "pipeline/outputs/elasticsearch.md", "range": {"start": {"line": 163, "column": 6}}}, "severity": "INFO"}
Error: reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.

@eschabell eschabell added dco DCO failing waiting-on-review Waiting on a review from mainteners labels Oct 22, 2025
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making suggestions to correct vale warnings.

@esmerel esmerel removed the dco DCO failing label Oct 23, 2025
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 950cda7 to c200512 Compare October 23, 2025 20:27
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from c200512 to ea63874 Compare October 28, 2025 01:42
@mabrarov mabrarov requested a review from esmerel October 28, 2025 13:31
@esmerel esmerel removed the waiting-on-review Waiting on a review from mainteners label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants