-
Couldn't load subscription status.
- Fork 538
es_out: support Upstream Servers with configuration overriding #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
es_out: support Upstream Servers with configuration overriding #1143
Conversation
cb36f75 to
7611f0e
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This pull request is waiting for review of fluent/fluent-bit#7608 |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
7611f0e to
25c7642
Compare
25c7642 to
7138a28
Compare
7138a28 to
c1092dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left suggestions, but I've added my technical writing-based approval based on that to keep this moving.
Primarily, I was looking to help the table be more consistent and readable, while implementing some style-based suggestions for consistency.
a78ebf2 to
c620db5
Compare
|
Hi @cnorris-cs, I applied some (!) parts of your suggestions as well as introduced additional changes for consistency with your suggestions. Please take a look at this pull request one more time when you have time. Some of the changes are implemented in dedicated commits (for ease of revert in case of concerns) - please let me know if I need to squash all commits into a single one. Thank you for your review. |
c620db5 to
23f04ef
Compare
23f04ef to
d8bad1b
Compare
d8bad1b to
d465436
Compare
|
This still looks ok to me from a writing perspective. |
8ed632e to
af68253
Compare
c02d041 to
312b9a1
Compare
312b9a1 to
02dbd5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor stylistic suggestions for consistency, but these docs changes look good to me otherwise.
02dbd5d to
da614db
Compare
dee1a67 to
6379bf2
Compare
6379bf2 to
dd6d5da
Compare
dd6d5da to
a458946
Compare
9d9fc20 to
e38893e
Compare
|
@esmerel can you look at the Vale check failures, I'm seeing this error before: Raw Output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making suggestions to correct vale warnings.
950cda7 to
c200512
Compare
Signed-off-by: Marat Abrarov <[email protected]>
Signed-off-by: Marat Abrarov <[email protected]>
…d on review comments. Signed-off-by: Marat Abrarov <[email protected]>
Signed-off-by: Marat Abrarov <[email protected]>
Signed-off-by: Marat Abrarov <[email protected]>
c200512 to
ea63874
Compare
Implementation of Upstream feature for the Elasticsearch output plugin.
Refer to fluent/fluent-bit#7608 for the changes in Fluent Bit code.