id: fixed a potential leak when a malformed string is processed

Signed-off-by: Leonardo Alminana <[email protected]>
fluent · Feb 9, 2023 · c22d413 · c22d413
1 parent be0ec8e
commit c22d413
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/ctr_id.c b/src/ctr_id.c
@@ -242,11 +242,12 @@ struct ctrace_id *ctr_id_from_base16(cfl_sds_t id)
         input_index++;
     }
 
-    if (!result) {
-        return NULL;
+    if (result) {
+        result_id = ctr_id_create(decoded_id, length / 2);
+    }
+    else {
+        result_id = NULL;
     }
-
-    result_id = ctr_id_create(decoded_id, length / 2);
 
     cfl_sds_destroy(decoded_id);