Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode_cloudwatch_emf_payload: Support EMF adopted payload encoder #192

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

cosmo0920
Copy link
Contributor

To handle EMF formatting for cmetrics context, we need to add emf payload encoder for cloudwatch_logs.

@edsiper
Copy link
Member

edsiper commented Jan 12, 2024

@cosmo0920 thanks for this.

I would suggest to rename the prototype of the API and remove the payload from the function names, e.g:

from cmt_encode_cloudwatch_emf_payload_create() to cmt_encode_cloudwatch_emf_create()

@cosmo0920
Copy link
Contributor Author

Thanks for your suggestion. I removed 'payload' from functions and files names.

@edsiper edsiper merged commit 82cf0ce into master Jan 14, 2024
18 checks passed
@edsiper edsiper deleted the cosmo0920-emf-encoder-payload branch January 14, 2024 15:50
@cosmo0920
Copy link
Contributor Author

🎉

@cosmo0920 cosmo0920 restored the cosmo0920-emf-encoder-payload branch February 2, 2024 12:32
@cosmo0920 cosmo0920 deleted the cosmo0920-emf-encoder-payload branch February 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants