Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakelists.txt: Stop using Make automatic variable #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CMakelists.txt: Stop using Make automatic variable #54

wants to merge 1 commit into from

Commits on Oct 7, 2024

  1. CMakelists.txt: Stop using Make automatic variable 

    CMake Makefile layout generation has changed since version 3.20, ref:
https://discourse.cmake.org/t/base-filename-gets-set-to-compiler-depend-ts-after-update-to-cmake-3-20/3075/4

For instance with Yocto framework this approach can lead to QA issue
stemming from build host path ending up in generated binary like

  ERROR: fluentbit-3.1.9-r0 do_package_qa: QA Issue: File /usr/bin/fluent-bit in package fluentbit contains reference to TMPDIR [buildpaths]
  ERROR: fluentbit-3.1.9-r0 do_package_qa: Fatal QA errors were found, failing task.

stemming from

  $ strings packages-split/fluentbit/usr/bin/fluent-bit
  ...
  $(subst /yocto/upstream/build/tmp/work/cortexa57-poky-linux/fluentbit/3.1.9/git/,,$(abspath $<))
  ...

Signed-off-by: Niko Mauno <[email protected]>
    @nikomauno
    nikomauno committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    089d5f4 View commit details
    Browse the repository at this point in the history