Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Http module #122

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor Http module #122

wants to merge 8 commits into from

Conversation

ZenVoich
Copy link
Contributor

@ZenVoich ZenVoich commented Jul 18, 2023 •
edited
Loading

fixes #99
fixes #113

Now only works with redirect.
Removed legacyPlaceholder setting.

ZenVoich
ZenVoich commented Aug 7, 2023
View reviewed changes
src/Http/lib.mo
};
};
case (_) {};
ignore do ? {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@letmejustputthishere Should we add reveal check and show placeholder here too?

@ZenVoich ZenVoich marked this pull request as ready for review August 7, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letmejustputthishere letmejustputthishere Awaiting requested review from letmejustputthishere

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use http parse to parse requests remove unnecessary http code
1 participant
@ZenVoich