Skip to content

Conversation

pengyuan-zhou
Copy link
Contributor

@pengyuan-zhou pengyuan-zhou commented Jun 11, 2020

Hi,

This is a branch to enable DQN (also by ray) for flow.
Currently it supports single agent and multi-agent tests on traffic_light_grid scripts.

Other examples can be easily enabled by modifying corresponding example file, env file and test file, according to the modifications in this branch.

Cheers,
Pengyuan

@pengyuan-zhou
Copy link
Contributor Author

Ya I have zero ideas why the build fails, it works on my pc (without the unittest).

@eugenevinitsky
Copy link
Member

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

@pengyuan-zhou
Copy link
Contributor Author

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

Sure, I'll revise it. BTW in that train.py, is the TD3 in setup_exps_rllib same with the one in h-baseline?

@pengyuan-zhou pengyuan-zhou requested a review from kjang96 as a code owner July 24, 2020 13:38
@eugenevinitsky
Copy link
Member

This looks good to me minus comments! @pengyuan-zhou if the changes are made I will merge.

@pengyuan-zhou
Copy link
Contributor Author

@eugenevinitsky
Copy link
Member

Hey! I'm really sorry about the state of things here, we are working on getting a new maintainer in the next week or so so this doesn't happen again.

@pengyuan-zhou
Copy link
Contributor Author

@eugenevinitsky Hi Eugene, wondering if there could be an update, though it's been years

@eugenevinitsky
Copy link
Member

Hi Pengyuan, I'm really sorry but this is just completely outside of our capabilities at this point. We have tried for ages to find a maintainer and no one seems up to it. I'll just merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants