Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new KeyHolder generator #592

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

tljuniper
Copy link
Contributor

This adds a new generator with a row of hooks for small items such as keys, cables or small bags.

The number of hooks, their size and distance to each other as well as the size of the back plate are customisable. I did some test cuts and ended up with a rounded shape for the top of the hooks to make sliding items on the hooks easier.

There is also the option to add mounting holes although some playing around with the settings is needed so that they don't overlap with the hook fingerholes.

From my perspective, this is pretty much done. Please let me know if I need to make any changes or if I've missed anything. I would also love some feedback on the generator name, as well as the parameters and their defaults, since I only know of my use case.

In any case: Thanks for the awesome project! This was a lot of fun to work with and I've used boxes.py for creating quite a few boxes by now :)

@tljuniper tljuniper force-pushed the keyholder-generator branch from fb80896 to 4f52180 Compare December 5, 2023 15:22
@tljuniper
Copy link
Contributor Author

I've just rebased to fix a merge conflict in samples.sha256.

@ffesti Is there anything I can do to get this merged? Or would you like me to close this instead?

@florianfesti florianfesti merged commit c8f7fa5 into florianfesti:master Dec 5, 2023
5 checks passed
@florianfesti
Copy link
Owner

Sorry, this one fell through the cracks.

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants