-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 2FA otp #145
feat: support 2FA otp #145
Conversation
I wonder where we should document it, maybe in |
I want to ignore the case of the input environment variable opt, so I defined lowercase and uppercase. |
I think having it lowercase is better since it matches the changeset api. I don't think we need to allow a lot of things, it's a template. If people prefer another way, they can update the script after cloning it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides Florian's points LGTM.
Also think it might be worth documenting somewhere
Co-authored-by: Sgal Cheung <[email protected]>
Implement issue 142.