Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 2FA otp #145

Merged

Conversation

sgalcheung
Copy link
Contributor

Implement issue 142.

scripts/release.mjs Outdated Show resolved Hide resolved
scripts/release.mjs Outdated Show resolved Hide resolved
@florian-lefebvre
Copy link
Owner

I wonder where we should document it, maybe in DELETE_ME

@florian-lefebvre florian-lefebvre linked an issue Dec 3, 2024 that may be closed by this pull request
scripts/release.mjs Outdated Show resolved Hide resolved
@sgalcheung
Copy link
Contributor Author

I want to ignore the case of the input environment variable opt, so I defined lowercase and uppercase.
Whether we have a better way to handle this? Or using a standard way is acceptable.

@florian-lefebvre
Copy link
Owner

I think having it lowercase is better since it matches the changeset api. I don't think we need to allow a lot of things, it's a template. If people prefer another way, they can update the script after cloning it

Copy link
Collaborator

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Florian's points LGTM.

Also think it might be worth documenting somewhere

@florian-lefebvre florian-lefebvre merged commit f53fc2a into florian-lefebvre:main Dec 3, 2024
1 check passed
@florian-lefebvre florian-lefebvre changed the title enhancement: support 2FA, you can use the --otp flag or -OTP flag. feat: support 2FA otp Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we create a git tag for ourselves?
3 participants