use os.path.join to get correct path under windows

[mattiasljungstrom]

For some reason this is working in your repository, but I had my github CI workflow choke on the fips path composition with + '/fips' when I upgraded to windows-latest from windows-2016.

When I changed it to use os.path.join it worked instead. Figured I'll submit it upstream.

[floooh]

Oh no this doesn't look good :/ I hope this isn't a general problem because I would need to update all the decentralized fips-files in all projects...

Can you post the error message that you get? Unfortunately I'm currently on vacation in the mountains, and while I have a Windows laptop with me I can't risk a Windows Update with sort of internet connection I have here :)

[mattiasljungstrom]

I've never seen this on my actual windows dev computer, only on github CI with "windows-latest". What happens was that the path for fips looked like this, and then it just died. (I've changed my actual project name to PROJECTDIR below.

Cloning into 'D:\a\PROJECTDIR/fips'...
##[error]Process completed with exit code 1.

adding a bit more error checking gave me this:

=== cloning fips build system to 'D:\a\PROJECTDIRips':
fatal: could not create work tree dir 'D:\a\PROJECTDIR?ips': Invalid argument

[floooh]

this looks to me like some tools in github CI try to interpret the /f as a command line argument or something, very strange.... I'll keep an eye out, my own github actions scripts should run into the same issue....

[mattiasljungstrom]

Could be it, at first I thought it was treating "/f" as an escape sequence. You can see how it eats the character in the bottom two lines.