Remove dispatch catch useless blocks

src/App.tsx

@@ -6,7 +6,6 @@ import { useLocation } from 'react-router';
 import NavigationDrawer from './components/menu/NavigationDrawer';
 import { ThemeContext } from './contexts/ThemeContextProvider';
 import { auth } from './firebase/Firebase';
-import useNotification from './hooks/useNotification';
 import { useAppDispatch, useAppSelector } from './store/hooks';
 import { setUser } from './store/slices/authSlice';
 import { getAbsences } from './store/thunks/absencesThunks';
@@ -17,8 +16,6 @@ import AnalyticsTracker from './utils/AnalyticsTracker';
 import { darkThemeOptions, lightThemeOptions } from './utils/MyThemeOptions';
 
 const App = () => {
-  const notifyContext = useNotification().notifyContext;
-
   const dispatch = useAppDispatch();
   const user = useAppSelector((state) => state.auth.user);
 
@@ -41,24 +38,13 @@ const App = () => {
   useEffect(() => {
     if (user && user.uid) {
       // Check if user is logged in
-      dispatch(loadProfile(undefined))
-        .catch((error) => {
-          console.error('Error loading profile: ', error);
-          notifyContext.addNotification('Error loading profile: ' + error, 'error');
-        })
-        .then(() => {
-          // Load times from firestore
-          dispatch(getTimes(undefined)).catch((error) => {
-            console.error('Error loading data: ', error);
-            notifyContext.addNotification('Error loading data: ' + error, 'error');
-          });
+      dispatch(loadProfile(undefined)).then(() => {
+        // Load times from firestore
+        dispatch(getTimes(undefined));
 
-          // Load absences from firestore
-          dispatch(getAbsences(undefined)).catch((error) => {
-            console.error('Error loading absences: ', error);
-            notifyContext.addNotification('Error loading absences: ' + error, 'error');
-          });
-        });
+        // Load absences from firestore
+        dispatch(getAbsences(undefined));
+      });
     }
   }, [user]);
 

src/components/UnautheticatedHomePage.tsx

@@ -1,23 +1,18 @@
 import GoogleIcon from '@mui/icons-material/Google';
 import { Box, Button, Link, Stack, Typography } from '@mui/material';
-import useNotification from '../hooks/useNotification';
 import { useAppDispatch } from '../store/hooks';
 import { googleSignIn } from '../store/thunks/authThunks';
 import { ReactComponent as HomeSvg } from '../svg/home.svg';
 import Item from './common/Item';
 
 const UnautheticatedHomePage = () => {
   const dispatch = useAppDispatch();
-  const { notifyContext } = useNotification();
 
   /*
     Handle Google Signup with Firebase Auth
   */
   const handleGoogleSignup = () => {
-    dispatch(googleSignIn(undefined)).catch((error) => {
-      console.error(error);
-      notifyContext.addNotification(error, 'error');
-    });
+    dispatch(googleSignIn(undefined));
   };
 
   return (

src/components/absences/AbsencesCard.tsx

@@ -36,10 +36,8 @@ const AbsencesCard = ({ days }: AbsencesCardProperties) => {
 
   // Remove an absence from the list
   const remove = (absence: IAbsence) => {
-    dispatch(deleteAbsence(absence)).catch((error) => {
-      console.error(error);
-      notifyContext.addNotification(error, 'error');
-    });
+    dispatch(deleteAbsence(absence));
+    notifyContext.addNotification('Abwesenheit wurde gelöscht', 'success');
 
     setAbsences((prevState) => {
       if (prevState) {

src/components/absences/NewAbsence.tsx

@@ -2,7 +2,6 @@ import { Button, Card, CardContent, FormControl, InputLabel, MenuItem, Select, S
 import { Dayjs } from 'dayjs';
 import locale from 'dayjs/locale/de';
 import { useEffect, useState } from 'react';
-import { useNavigate } from 'react-router';
 import useNotification from '../../hooks/useNotification';
 import { IAbsence, absenceTypes } from '../../interfaces/Types';
 import { useAppDispatch, useAppSelector } from '../../store/hooks';
@@ -16,7 +15,7 @@ const NewAbsence = () => {
   const [absenceType, setAbsenceType] = useState<string | null>(null);
   const [absences, setAbsences] = useState<IAbsence[]>([]);
   const { notifyContext } = useNotification();
-  const navigate = useNavigate();
+
   const dispatch = useAppDispatch();
 
   // The DateRangePicker component is used to select a range of dates.
@@ -42,8 +41,8 @@ const NewAbsence = () => {
     } else {
       if (absences.length > 0) {
         dispatch(addAbsences(absences));
+        notifyContext.addNotification('Abwesenheit wurde gespeichert', 'success');
       }
-      navigate('/absences/view');
     }
   };
 

src/components/settings/TabMyDataCard.tsx

@@ -99,10 +99,8 @@ const TabMyDataCard = () => {
     if (availableTimePerDay) newProfile.availabletime = TimeUtils.minutesFromTime(availableTimePerDay);
     if (numWorkday) newProfile.numWorkday = TimeUtils.numWorkdays(wd);
 
-    dispatch(updateProfile(newProfile)).catch((error) => {
-      console.error(error);
-      notifyContext.addNotification(error.message, 'error');
-    });
+    dispatch(updateProfile(newProfile));
+    notifyContext.addNotification('Profil wurde gespeichert', 'success');
   };
 
   return (

src/components/settings/TabMyProfileCard.tsx

@@ -14,10 +14,8 @@ const TabMyProfileCard = () => {
     Handle Delete Account
   */
   const deleteAccount = () => {
-    dispatch(deleteMyUser(undefined)).catch((error) => {
-      console.error(error);
-      notifyContext.addNotification(error, 'error');
-    });
+    dispatch(deleteMyUser(undefined));
+    notifyContext.addNotification('Dein Account wurde gelöscht', 'success');
   };
 
   return (

src/components/time/TimeEditPage.tsx

@@ -2,6 +2,7 @@ import ArrowBackIcon from '@mui/icons-material/ArrowBack';
 import BeachAccessIcon from '@mui/icons-material/BeachAccess';
 import { Box, Button, Card, CardContent, IconButton, Stack, TextField, Typography } from '@mui/material';
 import { useEffect, useState } from 'react';
+import useNotification from '../../hooks/useNotification';
 import { ITime, IWorkingdays } from '../../interfaces/Types';
 import { useAppDispatch, useAppSelector } from '../../store/hooks';
 import { addTimes, deleteTime } from '../../store/thunks/timesThunks';
@@ -20,6 +21,7 @@ const TimeEditPage = ({ editDate, handleClose }: TimeEditPageProps) => {
   const times = useAppSelector((state) => state.times.times);
 
   const dispatch = useAppDispatch();
+  const { notifyContext } = useNotification();
 
   const day = editDate;
 
@@ -77,6 +79,7 @@ const TimeEditPage = ({ editDate, handleClose }: TimeEditPageProps) => {
   const save = () => {
     if (time) {
       dispatch(addTimes([time]));
+      notifyContext.addNotification('Eintrag wurde gespeichert', 'success');
       handleClose();
     }
   };
@@ -85,8 +88,11 @@ const TimeEditPage = ({ editDate, handleClose }: TimeEditPageProps) => {
   If the user has entered all the data and clicks on the delete button, the data is deleted from the Firestore DB.
   */
   const deleteThisItem = () => {
-    if (time) dispatch(deleteTime(DayjsUtils.formatStringAsDay(day)));
-    handleClose;
+    if (time) {
+      dispatch(deleteTime(DayjsUtils.formatStringAsDay(day)));
+      notifyContext.addNotification('Eintrag wurde gelöscht', 'info');
+      handleClose();
+    }
   };
 
   return (

src/components/time/TimeInputPage.tsx

@@ -30,10 +30,8 @@ const TimeInputPage = () => {
   At the end only one batch is sent and its success or failure is reported.
   */
   const save = () => {
-    dispatch(addTimes(myTimes)).catch((error) => {
-      console.error(error);
-      notifyContext.addNotification(error, 'error');
-    });
+    dispatch(addTimes(myTimes));
+    notifyContext.addNotification('Zeiten wurden gespeichert', 'success');
   };
 
   /*

src/index.tsx

@@ -1,6 +1,5 @@
 import ReactDOM from 'react-dom/client';
 import { Provider } from 'react-redux';
-import { BrowserRouter } from 'react-router-dom';
 import App from './App';
 import Notification from './components/common/Notification';
 import { NotificationContextProvider } from './contexts/NotificationContextProvider';
@@ -11,18 +10,14 @@ import { store } from './store/store';
 
 const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
 root.render(
-  <>
-    <BrowserRouter>
-      <ThemeContextProvider>
-        <NotificationContextProvider>
-          <Provider store={store}>
-            <App />
-          </Provider>
-          <Notification />
-        </NotificationContextProvider>
-      </ThemeContextProvider>
-    </BrowserRouter>
-  </>
+  <ThemeContextProvider>
+    <NotificationContextProvider>
+      <Provider store={store}>
+        <App />
+      </Provider>
+      <Notification />
+    </NotificationContextProvider>
+  </ThemeContextProvider>
 );
 
 serviceWorkerRegistration.register();

src/store/thunks/authThunks.ts

@@ -28,6 +28,7 @@ export const deleteMyUser = createAsyncThunk('auth/delete', async (action: any,
     deleteUser(user).catch((error) => {
       console.error(error);
     });
+    logout(undefined);
   }
 });