Skip to content

Conversation

@erka
Copy link
Contributor

@erka erka commented Oct 14, 2025

Modernize OpenTelemetry gRPC instrumentation by migrating from deprecated
interceptors to the newer stats handler API supported by grpchan.

@erka erka requested a review from a team as a code owner October 14, 2025 21:00
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 14, 2025
@dosubot
Copy link

dosubot bot commented Oct 14, 2025

Documentation Updates

Checked 4 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.27%. Comparing base (96b3019) to head (9dc2109).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
internal/cmd/grpc.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4895      +/-   ##
==========================================
- Coverage   60.29%   60.27%   -0.03%     
==========================================
  Files         136      136              
  Lines       13375    13373       -2     
==========================================
- Hits         8065     8061       -4     
- Misses       4629     4630       +1     
- Partials      681      682       +1     
Flag Coverage Δ
integrationtests 34.92% <33.33%> (-0.02%) ⬇️
unittests 51.29% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka force-pushed the rd/v2/inproc-stats branch from 80848db to d6df69e Compare October 15, 2025 09:47
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
@erka erka force-pushed the rd/v2/inproc-stats branch from 3e60ce8 to 2667d91 Compare October 15, 2025 21:52
@markphelps
Copy link
Collaborator

thank you! id like to wait for this to get merged into the upstream instead of depending on a fork if possible

@erka erka force-pushed the rd/v2/inproc-stats branch from 2667d91 to 35f86b5 Compare October 23, 2025 12:27
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 23, 2025
@erka erka force-pushed the rd/v2/inproc-stats branch 3 times, most recently from e4da2f2 to d9d0986 Compare October 28, 2025 11:11
erka added 4 commits October 29, 2025 15:53
Modernize OpenTelemetry gRPC instrumentation by migrating from deprecated
interceptors to the newer stats handler API supported by grpchan.

Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
@erka erka force-pushed the rd/v2/inproc-stats branch from d9d0986 to 9dc2109 Compare October 29, 2025 15:55
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you for taking this on

@erka erka added the v2 Flipt v2 label Oct 29, 2025
@erka erka merged commit 0d67a97 into v2 Oct 29, 2025
28 of 30 checks passed
@erka erka deleted the rd/v2/inproc-stats branch October 29, 2025 22:47
@github-project-automation github-project-automation bot moved this to Done in Flipt V2 Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants