Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add OFREP ITs #3338

Merged
merged 3 commits into from
Aug 4, 2024
Merged

chore: Add OFREP ITs #3338

merged 3 commits into from
Aug 4, 2024

Conversation

markphelps
Copy link
Collaborator

Fixes: #3325

  • Adds basic ITs for OFREP single evaluation API
  • Moves snapshot IT to use readonly data instead of creating data in the test

Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
@markphelps markphelps requested a review from a team as a code owner August 3, 2024 15:54
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.39%. Comparing base (aa21195) to head (c79f24d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3338   +/-   ##
=======================================
  Coverage   64.39%   64.39%           
=======================================
  Files         172      172           
  Lines       13721    13721           
=======================================
  Hits         8836     8836           
  Misses       4207     4207           
  Partials      678      678           
Flag Coverage Δ
unittests 64.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Aug 3, 2024
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kodiakhq kodiakhq bot merged commit 0c0ba67 into main Aug 4, 2024
59 checks passed
@kodiakhq kodiakhq bot deleted the ofrep-its branch August 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-1119] Add OFREP Integration Tests
2 participants