Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make kafka schema registry an object #3270

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

markphelps
Copy link
Collaborator

make kafka schema registry an object in case there are future properties we want to configure on it

@markphelps markphelps requested a review from a team as a code owner July 12, 2024 17:36
Signed-off-by: Mark Phelps <[email protected]>
@erka
Copy link
Collaborator

erka commented Jul 12, 2024 via email

@markphelps markphelps requested a review from erka July 12, 2024 17:44
@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (3e72b57) to head (0e7f49b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3270   +/-   ##
=======================================
  Coverage   64.09%   64.09%           
=======================================
  Files         168      168           
  Lines       13393    13393           
=======================================
  Hits         8584     8584           
  Misses       4149     4149           
  Partials      660      660           
Flag Coverage Δ
unittests 64.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps merged commit dc5a029 into main Jul 13, 2024
56 checks passed
@markphelps markphelps deleted the kafka-schema-reg-url branch July 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants