-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support etag header for client-side eval #3240
Conversation
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
@markphelps your code looks great but there is a problem. If you have the namespace with some amount of flags and segments Here is the sample > curl -v http://localhost:8080/internal/v1/evaluation/snapshot/namespace/default
* Request completely sent off
< HTTP/1.1 200 OK
< Content-Length: 7011
< Content-Type: application/json
< Etag: 4bbaa020a72c5bd21b224bcdd11c5bf4c7c0cda3
> curl -v http://localhost:8080/internal/v1/evaluation/snapshot/namespace/default
* Request completely sent off
< HTTP/1.1 200 OK
< Content-Length: 7011
< Content-Type: application/json
< Etag: 92e8e67b990930eca494f3feb4536c68725dc2bf |
gah you are right. good find @erka . back to the drawing board it seems |
Its likely related to us using we need to think of otherways we can produce a stable etag value |
closing for another approach |
Re: flipt-io/flipt-client-sdks#294
Support etag/if-none-match headers for client-side eval endpoint