Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support environment variable substitution in config files #3195

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

mbezhanov
Copy link
Contributor

@mbezhanov mbezhanov commented Jun 19, 2024

Hi.

This PR implements the changes suggested in #2844.

The proposed format is ${VARIABLE} like in the envsubst Linux command, but I can tweak it however you like.

If any further changes are necessary, I'll be happy to add them.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.55%. Comparing base (f997fb9) to head (2a618a2).
Report is 427 commits behind head on main.

Current head 2a618a2 differs from pull request most recent head 2fab1f5

Please upload reports for the commit 2fab1f5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3195      +/-   ##
==========================================
+ Coverage   70.78%   71.55%   +0.76%     
==========================================
  Files          91      109      +18     
  Lines        8729     8004     -725     
==========================================
- Hits         6179     5727     -452     
+ Misses       2165     1848     -317     
- Partials      385      429      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @mbezhanov !! thank you for the contribution! would you mind going through the step required to sign the DCO?

https://github.com/flipt-io/flipt/pull/3195/checks?check_run_id=26421002517

@markphelps markphelps added the needs docs Requires documentation updates label Jun 19, 2024
@markphelps
Copy link
Collaborator

@all-contributors please add @mbezhanov for code

Copy link
Contributor

@markphelps

I've put up a pull request to add @mbezhanov! 🎉

@mbezhanov
Copy link
Contributor Author

looks great @mbezhanov !! thank you for the contribution! would you mind going through the step required to sign the DCO?

https://github.com/flipt-io/flipt/pull/3195/checks?check_run_id=26421002517

Done! 🙂

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jun 19, 2024
@kodiakhq kodiakhq bot merged commit a0cbc0c into flipt-io:main Jun 19, 2024
30 checks passed
markphelps added a commit that referenced this pull request Jun 19, 2024
…o authz-opa-sdk

* 'authz-opa-sdk' of https://github.com/flipt-io/flipt:
  docs: add mbezhanov as a contributor for code (#3197)
  feat: support environment variable substitution in config files (#3195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs needs docs Requires documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants