-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authn): allow validation of jwt subject claim #2995
Conversation
b7eae99
to
92e7cd0
Compare
@markphelps. I would like to have a bit more clarity about it. Usually jwt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markphelps It looks great. It would be nice to have two extra subtests in TestJWTAuthenticationInterceptor
with testing sub
I would think so as well, however the JWT library we use that performs the validation also only validates a single subject: https://github.com/hashicorp/cap/blob/1b8eac34c97dffae4f63761b6848c8a4e5590d54/jwt/jwt.go#L164-L166 |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
58b1f93
to
b9e8cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕶️
Re: #2985
subject
in JWT claims/cc @tstraley