Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change to segmentKeys for future proofing #1918

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Conversation

markphelps
Copy link
Collaborator

changes segmentKey for new evaluation API for /variant to be segmentKeys to support future #1882

@markphelps markphelps requested a review from a team as a code owner July 28, 2023 15:26
 into rollouts-segmentKeys

* 'rollouts-segmentKeys' of https://github.com/flipt-io/flipt:
  chore(production): use same configuration for default
  chore(rollouts): account for segments without constraints
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1918 (1408e3d) into main (d3c0cb4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1918   +/-   ##
=======================================
  Coverage   71.35%   71.35%           
=======================================
  Files          66       66           
  Lines        6455     6455           
=======================================
  Hits         4606     4606           
  Misses       1592     1592           
  Partials      257      257           
Files Changed Coverage Δ
internal/server/evaluation/evaluation.go 90.86% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps enabled auto-merge (squash) July 28, 2023 18:06
@markphelps markphelps disabled auto-merge July 28, 2023 18:23
@markphelps markphelps enabled auto-merge (squash) July 28, 2023 18:29
@markphelps markphelps merged commit c5da514 into main Jul 28, 2023
24 of 25 checks passed
@markphelps markphelps deleted the rollouts-segmentKeys branch July 28, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants