Adds Fleece request and response support #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've tried to avoid forcing users to use Fleece, but the fact of the matter is that without Fleece, we cannot generate the OpenAPI spec. So, this commit does two things: 1. Adds schema-specific constructors and handlers for `RequestBody` and `ResponseBody`. 2. Adds schema-specific response builder functions. They now use a dedicated function `addResponseSchema` to build them, which itself sets the content type as `application/json`.
telser
reviewed
Apr 4, 2025
| @@ -85,7 +87,11 @@ data NoRequestBody | |||
| = NoRequestBody | |||
|
|
|||
| data RequestBody body tags where | |||
| RequestBody :: | |||
| RequestSchema :: | |||
There was a problem hiding this comment.
Do we actually need this to be a separate constructor? I think we can do this by having an orb-fleece that wraps around orb to get this, and the other functionality, back.
There was a problem hiding this comment.
requestBody takes this type, so I don't see how we could do that without it just being a re-implementation of orb. Can you walk me through what you're thinking?
telser
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tried to avoid forcing users to use Fleece, but the fact of the matter is that without Fleece, we cannot generate the OpenAPI spec. So, this commit does two things:
Adds schema-specific constructors and handlers for
RequestBodyandResponseBody.Adds schema-specific response builder functions. They now use a dedicated function
addResponseSchemato build them, which itself sets the content type asapplication/json.