Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3940] Work around incorrect serial port handling by the OS #4040

Merged
merged 4 commits into from
Dec 23, 2024
Merged

[FL-3940] Work around incorrect serial port handling by the OS #4040

merged 4 commits into from
Dec 23, 2024

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Dec 19, 2024 •
edited by skotopes
Loading

What's new

  • The SDK falls back to filtering serial ports by VID:PID instead of the serial number, because the latter is reported incorrectly on some installations of Windows
  • Fixed incorrect handling of situations where no Flippers are connected or detected

Verification

  • Verify that the SDK successfully detects Flippers on weird installations of Windows

Remarks

I have already published the fixed SDK as version 0.1.3, since there's no CI/CD yet (DEVOPS-209)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3 portasynthinca3 added Bug JS JS Runtime, loader and API labels Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Compiled f7 firmware for commit a41260ec:

@skotopes skotopes merged commit 631d7a4 into dev Dec 23, 2024
10 of 11 checks passed
@skotopes skotopes deleted the portasynthinca3/3940-js-sdk-serial branch December 23, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Bug JS JS Runtime, loader and API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portasynthinca3 @skotopes