Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MFKey utility for NFC app flow #3943

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

noproto
Copy link
Contributor

@noproto noproto commented Oct 13, 2024

What's new

This PR supports PR #3822, and allows key recovery of MIFARE Classic smart cards to be performed fully on the Flipper Zero.

More information: #3874 (comment)

Verification

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

@noproto do you mind If we add missing part: nfc to mfkey integration?

@skotopes
Copy link
Member

Also it does looks like couple APIs is missing

@skotopes skotopes marked this pull request as draft October 14, 2024 19:52
@noproto
Copy link
Contributor Author

noproto commented Oct 14, 2024

@noproto do you mind If we add missing part: nfc to mfkey integration?

@skotopes That would be very helpful, I've been trying to understand what API could be used to launch it and free the active application (NFC->MFKey, MFKey->NFC on exit if NFC launches it). It would be a seamless process without immediately needing to optimize the NFC app's memory usage.

@noproto
Copy link
Contributor Author

noproto commented Oct 14, 2024

Detail: #3822 (comment)

@skotopes
Copy link
Member

Should we continue with this one?

@noproto
Copy link
Contributor Author

noproto commented Dec 23, 2024

Should we continue with this one?

@skotopes @RebornedBrain Yes. Some help is needed with launching the app from the NFC app, along with a return flow. The goal of this PR is to couple the key recovery with the NFC app, similar to hf mf autopwn on the Proxmark. I've been between jobs since we finished PR 3822 which had some unfortunate timing, but I still do plan to progress this series of PRs (and to MFKey directly to speed up static encrypted attacks).

In addition to the improvements we identified in PR 3822, I also am aiming to allow Nested to benefit from the cache file, and to fix a crash with ov-chipkaart. I've ordered an ov-chipkaart card to test with a week ago and it should be arriving shortly. Wr3nch was able to reproduce this crash.

Side note to this PR: I'm creating a new PR soon for an Ultralight C dictionary attack. I already have it running on the Zero, I'm fixing a few minor issues before I PR it. The PR will include almost 50 3DES keys. We are additionally verifying and testing a new practical process to recover keys on UL-C tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants