Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3643] Fix crash when reading files > 64B #3166

Merged
merged 4 commits into from
Oct 28, 2023
Merged

[FL-3643] Fix crash when reading files > 64B #3166

merged 4 commits into from
Oct 28, 2023

Conversation

gsurkov
Copy link
Member

@gsurkov gsurkov commented Oct 25, 2023 •
edited by gornekich
Loading

What's new

  • Support files up to 512B
  • Larger files are truncated, which is reflected both in the logs and GUI.
  • Support for saving and loading truncated files.

Verification

  1. Read a MF DESFire card with at least one regular file (size > 64B) on it.
  2. To check file truncation, a card with a file of size > 512B is needed. Create one from a blank card using Proxmark:
hf mfdes createapp --aid 123456
hf mfdes createfile --aid 123456 --fid 01 --size 000300
  1. Save MF DESFire card (it must have at least one regular file), then remove some data bytes from the saved file. Load it back in the app, it should mention "partial" in the file info.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gsurkov gsurkov added NFC NFC-related Bug labels Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Compiled f7 firmware for commit 9cd89dcf:

@skotopes skotopes merged commit cfaf745 into dev Oct 28, 2023
9 checks passed
@skotopes skotopes deleted the gsurkov/3643_mf_desfire_crash_fix branch October 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gornekich gornekich gornekich approved these changes

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
Bug NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsurkov @skotopes @gornekich