Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3621] Fix double arrows and add proper indication #3146

Merged
merged 3 commits into from
Oct 12, 2023
Merged

[FL-3621] Fix double arrows and add proper indication #3146

merged 3 commits into from
Oct 12, 2023

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Oct 12, 2023 •
edited by skotopes
Loading

What's new

  • Arrows no longer get corrupted when editing long HEX strings
  • Long hex strings show "..." for extra data

Verification

  • In the RFID app, create an AWID card and try editing the data, confirm the changes are present

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Compiled f7 firmware for commit 3b9546e9:

@flipperdevices flipperdevices deleted a comment from github-actions bot Oct 12, 2023
@skotopes skotopes merged commit e664159 into dev Oct 12, 2023
9 checks passed
@skotopes skotopes deleted the astra/3621-hex-fixes branch October 12, 2023 20:48
@hedger hedger added Bug UI Affects UI labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
Bug UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @hedger