Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3141: 12-bits is 0xFFF (or 0xFF0) CAME/NICE 12-bit #3142

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fix #3141: 12-bits is 0xFFF (or 0xFF0) CAME/NICE 12-bit #3142

merged 3 commits into from
Oct 12, 2023

Conversation

jamisonderek
Copy link
Contributor

@jamisonderek jamisonderek commented Oct 11, 2023

What's new

  • Fixes CAME 12-bit and NICE 12-bit to generate a random 12-bit key instead of a 16-bit key. The code was already only transmitting a 12-bit key, so this just makes the generated .SUB file 12-bits. Loading a previously generated .SUB file will still show the 16-bit key (the user can manually edit their .SUB file to only have the last three digits set if they care).

Verification

  • Sub-GHz, Add Manually, Nice Flo 12-bit_433, save file, load file, KEY should be 12-bits (3 digits) and YEK should be 12-bits. Writing out the binary for the KEY and reversing it should give you the YEK. Transmitting the signal should display matching KEY on second Flipper Zero.
  • Sub-GHz, Add Manually, CAME 12-bit_433, save file, load file, KEY should be 12-bits (3 digits) and YEK should be 12-bits. Writing out the binary for the KEY and reversing it should give you the YEK. Transmitting the signal should display matching KEY on second Flipper Zero.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@jamisonderek jamisonderek changed the title #3141 12-bits is 0xFFF (or 0xFF0) fix #3141: 12-bits is 0xFFF (or 0xFF0) CAME/NICE 12-bit Oct 11, 2023
@jamisonderek
Copy link
Contributor Author

I was trying to also fix #3143 and it looks like that fix also became part of this fix because I was working in the same branch.

What's new

Adds support for pairing 850LM with Add Manually Security+2.0 entry.

Verification

Sub-GHz, Add Manually, Security+2.0, save file, load file. Press pair button on 850LM receiver. Press OK on Flipper, device should pair. Press OK on Flipper again, device relay should click.

@skotopes skotopes added the Sub-GHz Sub-GHz-related label Oct 12, 2023
@skotopes skotopes merged commit 9d6352e into flipperdevices:dev Oct 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sub-GHz Sub-GHz-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants