-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ascii counter fix #3130
Merged
gornekich
merged 42 commits into
flipperdevices:gornek/nfc_refactoring_v1
from
RebornedBrain:berezhnoy/ascii_counter_fix
Oct 6, 2023
Merged
Ascii counter fix #3130
gornekich
merged 42 commits into
flipperdevices:gornek/nfc_refactoring_v1
from
RebornedBrain:berezhnoy/ascii_counter_fix
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both cmds now work through one function NtagI2C support added
Conflicts: firmware/targets/f7/api_symbols.csv
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
…fc_refactoring_v1
RebornedBrain
requested review from
skotopes,
DrZlo13,
hedger,
gornekich and
Astrrra
as code owners
October 5, 2023 08:47
gornekich
merged commit Oct 6, 2023
dae5d3d
into
flipperdevices:gornek/nfc_refactoring_v1
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Now counter updates properly in ascii mirror mode
Verification
NTAG213
hf 14a raw -sc A229840026FF //Enable ascii mirror in counter mode
hf 14a raw -sc A22A10050000 //Enable counter itself
hf 14a raw -sc 3025 //Read page 0x25
hf 14a raw -sc 3025 //Each ride counter should be +1
hf 14a raw -sc 3025
Checklist (For Reviewer)