Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbt: reworked tool path handling #3105

Merged
merged 5 commits into from
Sep 25, 2023
Merged

fbt: reworked tool path handling #3105

merged 5 commits into from
Sep 25, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Sep 23, 2023 •
edited by skotopes
Loading

What's new

Verification

  • Clone to path with spaces
  • Check that building firmware works
  • Check that vscode config works with clangd

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Sep 23, 2023 •
edited
Loading

Compiled f7 firmware for commit 8d061bfb:

@hedger hedger changed the title fbt: removed absolute paths from env setup; moved abs paths to cdb tool fbt: reworked tool path handling Sep 23, 2023
@skotopes skotopes merged commit e1030e7 into dev Sep 25, 2023
9 checks passed
@skotopes skotopes deleted the hedger/fbtspaces branch September 25, 2023 05:04
@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolchain version is not supported.
2 participants
@hedger @skotopes