Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3458] Add confirmation before exiting USB-UART #3043

Merged
merged 5 commits into from
Sep 21, 2023
Merged

[FL-3458] Add confirmation before exiting USB-UART #3043

merged 5 commits into from
Sep 21, 2023

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Sep 5, 2023 •
edited by skotopes
Loading

What's new

  • Exiting USB-UART now shows a dialog that can be dismissed by pressing Left, or cancelled by pressing Right. The back button does nothing in that dialog.

Verification

  • Enter and exit USB-UART

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Compiled firmware for commit 982fac82:

@Astrrra Astrrra marked this pull request as draft September 5, 2023 10:42
@hedger hedger marked this pull request as ready for review September 5, 2023 14:27
@hedger hedger marked this pull request as draft September 5, 2023 14:27
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

Compiled f7 firmware for commit 91697989:

@Astrrra Astrrra marked this pull request as ready for review September 18, 2023 08:19
@skotopes skotopes merged commit 182c8de into dev Sep 21, 2023
@skotopes skotopes deleted the astra/3458-usb-uart-exit-confirm branch September 21, 2023 08:06
@hedger hedger added USB BadUSB + physical USB interface UI Affects UI labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
UI Affects UI USB BadUSB + physical USB interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @hedger