Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest.yml changed the Path of readme.md #209

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Update manifest.yml changed the Path of readme.md #209

wants to merge 13 commits into from

Conversation

grugnoymeme
Copy link
Contributor

@grugnoymeme grugnoymeme commented Dec 3, 2023 •
edited by doomwastaken
Loading

Application Submission

  • Updated readme PATH that was broken.

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

@hedger hedger added app (update) fixes needed Unresolved issues with the app requiring maintainer's attention labels Dec 3, 2023
hedger
hedger requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@hedger hedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill in the PR's description and fix manifest validation errors.

@grugnoymeme grugnoymeme changed the title Update manifest.yml Update manifest.yml changed the Path of readme.md Dec 3, 2023
@grugnoymeme
Copy link
Contributor Author

Please fill in the PR's description and fix manifest validation errors.

hey i cannot understand why its not working as this..

@hedger
Copy link
Member

hedger commented Dec 6, 2023 •
edited
Loading

@grugnoymeme to merge an app update, it must include a new app version (set in application.fam). Please create a new commit with bumped version in your app's repo and update SHA in the manifest.

@hedger hedger marked this pull request as draft December 22, 2023 07:46
@hedger
Copy link
Member

hedger commented Dec 22, 2023

Un-draft when fixed.

@grugnoymeme grugnoymeme marked this pull request as ready for review November 1, 2024 06:50
@grugnoymeme
Copy link
Contributor Author

now should be ok

@doomwastaken
Copy link
Member

Currently it says that changelog is empty, add something to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
app (update) fixes needed Unresolved issues with the app requiring maintainer's attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grugnoymeme @hedger @doomwastaken