-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add ability to generate files in folders #10
base: main
Are you sure you want to change the base?
Conversation
Adding a new feature flag `prefix_schema_files_with_package` which results in the schema files being generated in folders based on the package of the message.
@dorner Do you have any interesting in accepting feature requests to this repo or should we just permanently fork? |
@ikstewa so sorry! I didn't have this repo as watched on my settings so I didn't see the original PR. I'm coming back from vacation but will take a look at these today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - had a couple of suggestions.
@ikstewa tests are failing - can you rebase off main and make sure you rerun tests? You can use |
Adding a new feature flag
prefix_schema_files_with_package
which results in the schema files being generated in folders based on the package of the message.