-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 rebased #220
base: master
Are you sure you want to change the base?
V2 rebased #220
Changes from 1 commit
0df10b4
6166045
dfbf84b
7b9dbba
0384a35
7e84e8a
250df19
b339b58
c33168e
eb34830
51b9571
ee9906f
1d6ebdb
4d25257
190bd8d
bb4d369
b6449db
b559f94
3834a85
5abd5b2
faa642e
6fe16d5
1721ea8
bec0a4d
69e4710
ac80a0d
f1a714c
9170520
c7a818f
76b1174
8484804
a1f2188
5958e18
5445d50
e91b806
b17e31c
a5e8b40
feb4c7f
a643915
687f55b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ruby 3.2.2 |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remember you pointed out specific ruby version to be a requirement. Would it be useful to add it to gemspec as a requirement? |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,6 @@ module Consume | |
# of messages to be handled at once | ||
module BatchConsumption | ||
extend ActiveSupport::Concern | ||
include Phobos::BatchHandler | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are quite a few references to Phobos on sig/defs.rbs file. I believe they needs to be removed too. |
||
|
||
# @param batch [Array<String>] | ||
# @param metadata [Hash] | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline_consumer and schema_controller_mixin can be removed as the files are removed in the PR.