-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for issue #196 #197
base: main
Are you sure you want to change the base?
Conversation
I've been testing locally with different payloads which fail on the app, but all of them make the test pass. The two possible scenarios that I think we might be in:
wdyt? |
The test looks very fine to me. One think I could imagine is happening is that the javascript object representation you've pasted in fails to capture some of the fine details of the objects created by dehydrating. Maybe you could try using the breaking code from #196 in the test? |
I'll be off on vacation for the coming weeks, so I won't be able to assist with this any further for now. If you find the issue, that means the fastest way to resolution is probably fixing it yourself and then opening a PR. Maybe @beerose and team can help with reviewing + publishing during that time. |
Yes, that makes sense. I'll use the actual I'll try to fix it myself, no worries. Enjoy your time off! |
I've updated the tests to use the actual EDIT: To my surprise, the tests continue passing. I've checked the object produced by The hypothesis that the issue might be on the babel plugin babel-plugin-superjson-next instead of this library is getting more points. What do you think should be the next steps? |
back from PTO! I'm not sure what's causing this. Maybe you could build a minimum reproduction repository? Then I could take a look and check if I can reproduce and have an idea what's causing it |
@Skn0tt I've added the test hardcoding the data that is creating the issue. However, the test is passing 🤷
I'm opening this PR so you can have a quick look and check if you see any red flag in the test I've written. I'm just hardcoding the value that's giving me trouble, stringifying, parsing, and checking that the parsed value and the hardcoded value are equal.
Let me know if you see something weird.
Thanks!