Skip to content

fix: disable default low freq smoothing #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

fix: disable default low freq smoothing #3025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions schemas/TerminalComponentModeler.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18245,15 +18245,7 @@
{
"$ref": "#/definitions/ModelerLowFrequencySmoothingSpec"
}
],
"default": {
"attrs": {},
"max_deviation": 0.5,
"max_sampling_time": 5.0,
"min_sampling_time": 1.0,
"order": 1,
"type": "ModelerLowFrequencySmoothingSpec"
}
]
},
"name": {
"default": "",
Expand Down
5 changes: 1 addition & 4 deletions tidy3d/plugins/smatrix/component_modelers/terminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ class ModelerLowFrequencySmoothingSpec(AbstractLowFrequencySmoothingSpec):
"""


DEFAULT_LOW_FREQUENCY_SMOOTHING_SPEC = ModelerLowFrequencySmoothingSpec()


class TerminalComponentModeler(AbstractComponentModeler, MicrowaveBaseModel):
"""
Tool for modeling two-terminal multiport devices and computing port parameters
Expand Down Expand Up @@ -208,7 +205,7 @@ class TerminalComponentModeler(AbstractComponentModeler, MicrowaveBaseModel):
)

low_freq_smoothing: Optional[ModelerLowFrequencySmoothingSpec] = pd.Field(
DEFAULT_LOW_FREQUENCY_SMOOTHING_SPEC,
None,
title="Low Frequency Smoothing",
description="The low frequency smoothing parameters for the terminal component simulation.",
)
Expand Down