Skip to content

Conversation

@MatthewSH
Copy link

@MatthewSH MatthewSH commented Oct 27, 2025

Related issue: Resolves #34801

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

@MatthewSH MatthewSH requested a review from a team as a code owner October 27, 2025 14:08
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.05%. Comparing base (6708e2d) to head (b8de5f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #34808      +/-   ##
==========================================
- Coverage   66.05%   66.05%   -0.01%     
==========================================
  Files        2066     2066              
  Lines      172701   172700       -1     
  Branches     6989     6988       -1     
==========================================
- Hits       114073   114072       -1     
  Misses      48108    48108              
  Partials    10520    10520              
Flag Coverage Δ
frontend 53.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] OS Settings on device page behind premium check despite not having any premium features

1 participant