-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS setup experience guide: end user authentication #24990
Open
noahtalerman
wants to merge
6
commits into
main
Choose a base branch
from
noahtalerman-patch-19
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
noahtalerman
commented
Dec 23, 2024
•
edited
Loading
edited
- Put "already configured SSO" message at the top b/c this scenario will apply to most users
- Add missing permissions for IdP for end user auth and end user migration
- Clean up language in docs
- Add redirects for the UI in case content moves later
- Put "already configured SSO" message at the top b/c this will apply to most users - Clean up language in docs - Add redirects for the UI
noahtalerman
had a problem deploying
to
Docker Hub
December 23, 2024 14:45 — with
GitHub Actions
Error
noahtalerman
had a problem deploying
to
Docker Hub
December 23, 2024 14:54 — with
GitHub Actions
Error
noahtalerman
had a problem deploying
to
Docker Hub
December 23, 2024 14:55 — with
GitHub Actions
Error
15 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24990 +/- ##
==========================================
- Coverage 63.57% 63.55% -0.03%
==========================================
Files 1607 1609 +2
Lines 152302 152420 +118
Branches 3878 3976 +98
==========================================
+ Hits 96825 96867 +42
- Misses 47763 47839 +76
Partials 7714 7714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
noahtalerman
had a problem deploying
to
Docker Hub
December 23, 2024 14:58 — with
GitHub Actions
Error
noahtalerman
temporarily deployed
to
Docker Hub
December 23, 2024 15:02 — with
GitHub Actions
Inactive
marko-lisica
previously requested changes
Dec 24, 2024
Co-authored-by: Marko Lisica <[email protected]>
Thanks for catching that typo @marko-lisica! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.