Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing field #24977

Merged
merged 4 commits into from
Dec 24, 2024
Merged

fix: add missing field #24977

merged 4 commits into from
Dec 24, 2024

Conversation

jahzielv
Copy link
Contributor

Related issue: #24970

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Added/updated tests
  • Manual QA for all new/changed functionality

gillespi314
gillespi314 previously approved these changes Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (38fcc30) to head (9c4d57c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
server/service/testing_client.go 77.96% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24977      +/-   ##
==========================================
+ Coverage   63.75%   63.80%   +0.04%     
==========================================
  Files        1610     1608       -2     
  Lines      153169   153106      -63     
  Branches     3962     3967       +5     
==========================================
+ Hits        97654    97683      +29     
+ Misses      47729    47625     -104     
- Partials     7786     7798      +12     
Flag Coverage Δ
backend 64.63% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv marked this pull request as ready for review December 23, 2024 15:29
@jahzielv jahzielv requested review from marko-lisica and a team as code owners December 23, 2024 15:29
marko-lisica
marko-lisica previously approved these changes Dec 23, 2024
Copy link
Member

@marko-lisica marko-lisica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audit logs docs look good to me!

marko-lisica
marko-lisica previously approved these changes Dec 23, 2024
@jahzielv jahzielv merged commit 3123324 into main Dec 24, 2024
27 checks passed
@jahzielv jahzielv deleted the 24970-fix branch December 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants