Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applied_spec_software for YAML software updates #24913

Draft
wants to merge 30 commits into
base: docs-v4.63.0
Choose a base branch
from

Conversation

eugkuo
Copy link
Contributor

@eugkuo eugkuo commented Dec 19, 2024

Referencing #24469

Drew-P-drawers and others added 26 commits December 17, 2024 17:31
Adding Sprint demos - 4.61.0 from YouTube to embed in the article
Closes: #24746

Changes:
- Replaced the hard-coded links to articles on the /testimonials page
with server-side rendered generated links to articles. These links are
now built using the website's markdown articles configuration.
- Added support for a new meta tag on articles:
`showOnTestimonialsPageWithEmoji` If provided and set to one of the four
supported emoji (🥀, 🔌, 🚪, or 🪟), a link to the article will be added to
the /testimonials page. Example: `<meta
name="showOnTestimonialsPageWithEmoji" value="🥀">`.
- Updated the build-static-content script to throw an error if an
article has an invalid `showOnTestimonialsPageWithEmoji` meta tag value.
- Updated recent case study articles to have a
`showOnTestimonialsPageWithEmoji` meta tag.


@Drew-P-drawers When this PR is merged, you can add links to the new
case studies articles to the /testimonials page with a
`showOnTestimonialsPageWithEmoji` meta tag. The definitions for each of
the supported emoji are in this [google
doc](https://docs.google.com/document/d/1-KWQa3uMIJzeitzDRmzT3SnUoFCfcFCb6K2lyVt-Gy0/edit?tab=t.0#heading=h.oskipmb8530l)
Pullled note on equity updates into a spot that makes more sense.
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
Add details about how to make an API design PR
… Python HTTP client directly to avoid needing to figure out how to pin requests lib (#24861)

For #24274. Skipping changes file since this is an internal tool.

# Checklist for submitter
- [x] Manual QA for all new/changed functionality
Closes: fleetdm/confidential#8983

Changes:
- Added /meetups, a page that shows a list of upcoming meetups
…e no hosts online. (#24858)

## #23800 

<img width="535" alt="Screenshot 2024-12-17 at 6 13 37 PM"
src="https://github.com/user-attachments/assets/5600a288-9b97-4b69-a561-43244c936de5"
/>

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
#24548

This PR covers Apple legacy commands, Windows commands, and scripts.
Apple DDM commands and Software install/uninstall scripts will be
covered in separate PRs.

# Checklist for submitter
- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
- Record KPI first before we move stories around
Changes:
- Updated the MSP dashboard's entrypoint.sh script to not rebuild the
database every time it starts with the --build flag.
#24549

Remove redundant code introduced in original PR #24624
Copy link
Member

@rachaelshaw rachaelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm! Should this PR be to a release docs branch or was this already implemented?

ksatter and others added 2 commits December 19, 2024 11:46
Updated /automations/reset description to reflect that this endpoint
does not immediately trigger automations, but resets the status of hosts
so that they are seen as newly failing on the next automation run.
Copy link
Member

@Sampfluger88 Sampfluger88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this PR should not be merged. It's pulling in all changes. Nvm just saw the above comment.

@rachaelshaw
Copy link
Member

rachaelshaw commented Dec 19, 2024

@eugkuo converting this PR to a draft; changing the base branch always seems to result in massive diffs (183 files changed 🫠) and auto-requests reviews from all the codeowners. I'm not sure how to fix it other than making a new PR.

Screenshot 2024-12-19 at 2 10 57 PM

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 55.88235% with 30 lines in your changes missing coverage. Please review.

Project coverage is 63.59%. Comparing base (c9bdae8) to head (27f6db7).
Report is 39 commits behind head on docs-v4.63.0.

Files with missing lines Patch % Lines
.../components/TableContainer/DataTable/DataTable.tsx 14.28% 6 Missing ⚠️
server/mdm/nanomdm/service/nanomdm/service.go 44.44% 3 Missing and 2 partials ⚠️
server/mdm/nanomdm/storage/allmulti/allmulti.go 0.00% 5 Missing ⚠️
server/service/microsoft_mdm.go 28.57% 3 Missing and 2 partials ⚠️
server/datastore/mysql/microsoft_mdm.go 63.63% 3 Missing and 1 partial ⚠️
server/service/orbit.go 20.00% 3 Missing and 1 partial ⚠️
frontend/components/forms/fields/Slider/Slider.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           docs-v4.63.0   #24913      +/-   ##
================================================
+ Coverage         63.56%   63.59%   +0.02%     
================================================
  Files              1603     1603              
  Lines            151958   152006      +48     
  Branches           3900     3871      -29     
================================================
+ Hits              96590    96661      +71     
+ Misses            47667    47650      -17     
+ Partials           7701     7695       -6     
Flag Coverage Δ
backend 64.39% <57.40%> (+0.03%) ⬆️
frontend 53.73% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eugkuo
Copy link
Contributor Author

eugkuo commented Dec 20, 2024

@rachaelshaw

@eugkuo converting this PR to a draft; changing the base branch always seems to result in massive diffs (183 files changed 🫠) and auto-requests reviews from all the codeowners. I'm not sure how to fix it other than making a new PR.

Thanks for doing this. Does that mean we should update the process here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.