Allow software uninstalls, script-based lock/unlock/wipe, while scripts are globally disabled #24815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24815 +/- ##
=======================================
Coverage 63.80% 63.80%
=======================================
Files 1612 1613 +1
Lines 153447 153432 -15
Branches 4003 4003
=======================================
- Hits 97907 97900 -7
+ Misses 47742 47735 -7
+ Partials 7798 7797 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…action with (un)install scripts
…ed lock/unlock/wipe TODO: * Fix tests * Write scripts to DB as eligible for skipping script disabled, read from DB when scripts disabled
…ed has no effect)
…s pending scripts when script execution is disabled globally
iansltx
force-pushed
the
22875-uninstall-with-scripts-disabled
branch
from
f1aa3d8 to
3e706c4
Compare
…ripts are disabled
jacobshandling
previously approved these changes
Dec 18, 2024
|
Repushed to renumber the migration as stuff has merged ahead of me. @RachelElysia I've assigned FE review to you as it should be quick. |
lucasmrod
previously approved these changes
Dec 26, 2024
server/datastore/mysql/migrations/tables/20241224000000_InternalHostScriptResults_test.go
Outdated
Show resolved
Hide resolved
# Conflicts: # ee/server/service/software_installers_test.go # server/datastore/mysql/schema.sql
lucasmrod
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #22875.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci).