Fleet UI: Add automatic install to custom packages upload #24729

RachelElysia · 2024-12-12T21:28:31Z

Issue

Story #23344
FE #24384

Description

Select manual or automatic install type when uploading a custom package

Screenshots/screen recording

Screen.Recording.2024-12-27.at.2.01.00.PM.mov

Tests updated

Checklist for submitter

If some of the following don't apply, delete the relevant line.

TODO: QA Wolf test request
Manual QA for all new/changed functionality

codecov · 2024-12-12T21:31:55Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (963cc7e) to head (a3555f4).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
frontend/services/entities/software.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #24729      +/-   ##
==========================================
- Coverage   63.79%   63.79%   -0.01%     
==========================================
  Files        1612     1612              
  Lines      153445   153447       +2     
  Branches     3984     4039      +55     
==========================================
  Hits        97897    97897              
- Misses      47745    47747       +2     
  Partials     7803     7803

Flag	Coverage Δ
frontend	`53.25% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RachelElysia · 2024-12-12T21:41:41Z

frontend/interfaces/software.ts

@@ -276,6 +277,7 @@ export interface ISoftwareInstallResult {
  post_install_script_output: string;
  created_at: string;
  updated_at: string | null;
+  automatic_install: boolean;


@lucasmrod Will this return? or is it just for post

Just for the POST. Because what makes the installer automated is the fact that it has a policy associated to it. The UI already renders the "Automatic install" using the automatic_install_policies field.

RachelElysia · 2024-12-12T21:42:02Z

frontend/interfaces/software.ts

@@ -306,6 +308,7 @@ export interface ISoftwareInstallVersion {

 export interface IHostSoftwarePackage {
  name: string;
+  automatic_install: boolean;


@lucasmrod Will this return? or is it just for post

#24729 (comment)

RachelElysia · 2024-12-17T20:29:12Z

This is ready for review except @lucasmrod might be changing the 424 error spec, so it's just in a holding pattern until BE is ready and merged

RachelElysia · 2024-12-19T15:47:21Z

@ghernandez345 last commit I converted to re-use the component you made and so it'll be easier for you to integrate with the labels work you're doing. I tagged you as a reviewer instead of @jacobshandling since we'll need to merge our work together anyway. Heads up looks like #23744 will be adding my section onto the vpp page as well so reusable components might be the way to go. Lmk if you think I should move it to it's own file or just wait until 23744 to do so. https://www.figma.com/design/OqlVvqpp5E6A7JOfdEKMR6/%2323744%3A-Create-policies-automatically-for-installing-App-Store-apps-(VPP)?t=ECOf6SUjyZZMuQYn-0

RachelElysia · 2024-12-27T17:36:12Z

frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/helpers.tsx

+        />
+      </>
+    );
+  } else if (reason.includes("Fleet couldn't read the version from")) {


@ghernandez345 I added this back but wasn't sure, lmk https://github.com/fleetdm/fleet/pull/25008/files#r1898638620

looks good thanks for catching

…n a .exe file

ghernandez345

Looks good. When you merge this in I will finish up the custom package form work.

ghernandez345 · 2024-12-27T19:11:56Z

...areFleetMaintained/FleetMaintainedAppDetailsPage/FleetAppDetailsForm/FleetAppDetailsForm.tsx

+}
+
+// Also used in custom package form (PackageForm.tsx)
+export const InstallTypeSection = ({


Looks good but if this also used in Package form I think it should live in that file and be imported here instead of the other way around. Seems strange to have components/PackageForm import a component from a specific page.

@ghernandez345 PackageForm.tsx is the custom package page's version of FMA's FleetAppDetailsForm.tsx, I was thinking of making a components directory for stuff that is used in both but since it was only this item, I just left it where it was, WDYT?

RachelElysia had a problem deploying to Docker Hub December 12, 2024 21:28 — with GitHub Actions Error

RachelElysia had a problem deploying to Docker Hub December 12, 2024 21:32 — with GitHub Actions Error

RachelElysia had a problem deploying to Docker Hub December 12, 2024 21:33 — with GitHub Actions Error

RachelElysia force-pushed the 23344-custom-package branch from 5a73d41 to 1685063 Compare December 12, 2024 21:38

RachelElysia had a problem deploying to Docker Hub December 12, 2024 21:38 — with GitHub Actions Failure

RachelElysia commented Dec 12, 2024

View reviewed changes

RachelElysia had a problem deploying to Docker Hub December 12, 2024 21:43 — with GitHub Actions Failure

RachelElysia had a problem deploying to Docker Hub December 13, 2024 14:25 — with GitHub Actions Failure

RachelElysia temporarily deployed to Docker Hub December 13, 2024 14:32 — with GitHub Actions Inactive

RachelElysia temporarily deployed to Docker Hub December 19, 2024 15:24 — with GitHub Actions Inactive

RachelElysia assigned ghernandez345 Dec 19, 2024

RachelElysia force-pushed the 23344-custom-package branch from bcbeb6c to ef0ad12 Compare December 27, 2024 15:41

RachelElysia had a problem deploying to Docker Hub December 27, 2024 15:41 — with GitHub Actions Failure

RachelElysia had a problem deploying to Docker Hub December 27, 2024 17:24 — with GitHub Actions Error

RachelElysia had a problem deploying to Docker Hub December 27, 2024 17:26 — with GitHub Actions Error

RachelElysia requested a review from lucasmrod December 27, 2024 17:27

RachelElysia temporarily deployed to Docker Hub December 27, 2024 17:32 — with GitHub Actions Inactive

RachelElysia marked this pull request as ready for review December 27, 2024 17:33

RachelElysia requested a review from a team as a code owner December 27, 2024 17:33

RachelElysia commented Dec 27, 2024

View reviewed changes

RachelElysia temporarily deployed to Docker Hub December 27, 2024 17:56 — with GitHub Actions Inactive

RachelElysia added 5 commits December 27, 2024 13:33

Flatten commits for easier rebase of main

18a4d6c

Default back to manual install type if user chooses automatic and the…

7edc587

…n a .exe file

Fix notes

173e76c

Update extraction error logic

6072d28

Yellow banner for custom package and not FMA

a3555f4

RachelElysia force-pushed the 23344-custom-package branch from 0ee3e8d to a3555f4 Compare December 27, 2024 18:33

RachelElysia temporarily deployed to Docker Hub December 27, 2024 18:33 — with GitHub Actions Inactive

ghernandez345 approved these changes Dec 27, 2024

View reviewed changes

RachelElysia merged commit 5319156 into main Dec 27, 2024
14 checks passed

RachelElysia deleted the 23344-custom-package branch December 27, 2024 19:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fleet UI: Add automatic install to custom packages upload #24729

Fleet UI: Add automatic install to custom packages upload #24729

RachelElysia commented Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading

RachelElysia Dec 12, 2024

lucasmrod Dec 12, 2024

RachelElysia Dec 12, 2024

lucasmrod Dec 12, 2024

RachelElysia commented Dec 17, 2024

RachelElysia commented Dec 19, 2024 •

edited

Loading

RachelElysia Dec 27, 2024

ghernandez345 Dec 27, 2024

ghernandez345 left a comment

ghernandez345 Dec 27, 2024

RachelElysia Dec 27, 2024

Fleet UI: Add automatic install to custom packages upload #24729

Fleet UI: Add automatic install to custom packages upload #24729

Conversation

RachelElysia commented Dec 12, 2024 • edited Loading

Issue

Description

Screenshots/screen recording

Tests updated

Checklist for submitter

codecov bot commented Dec 12, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RachelElysia commented Dec 17, 2024

RachelElysia commented Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghernandez345 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RachelElysia commented Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading

RachelElysia commented Dec 19, 2024 •

edited

Loading