Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicate MySQL indexes. #24107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+126 −13
Open

Drop duplicate MySQL indexes. #24107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ecaf7d
Drop duplicate MySQL indexes.
getvictor Nov 22, 2024
0148f7b
Added changes.
getvictor Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/24109-drop-duplicate-indexes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed duplicate indexes from the database schema.
117 changes: 117 additions & 0 deletions server/datastore/mysql/migrations/tables/20241122171434_RemoveDuplicateIndexes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
package tables

import (
"database/sql"
"fmt"
)

func init() {
MigrationClient.AddMigration(Up_20241122171434, Down_20241122171434)
}

func Up_20241122171434(tx *sql.Tx) error {
// Duplicate indexes identified after running pt-duplicate-key-checker
// https://docs.percona.com/percona-toolkit/pt-duplicate-key-checker.html

// # ########################################################################
// # fleet.app_config_json
// # ########################################################################
//
// # Uniqueness of id ignored because PRIMARY is a duplicate constraint
// # id is a duplicate of PRIMARY
// # Key definitions:
// # UNIQUE KEY `id` (`id`)
// # PRIMARY KEY (`id`),
// # Column types:
// # `id` int unsigned not null default '1'
// # To remove this duplicate index, execute:
// ALTER TABLE `fleet`.`app_config_json` DROP INDEX `id`;
//
// # ########################################################################
// # fleet.host_users
// # ########################################################################
//
// # idx_uid_username is a duplicate of PRIMARY
// # Key definitions:
// # UNIQUE KEY `idx_uid_username` (`host_id`,`uid`,`username`)
// # PRIMARY KEY (`host_id`,`uid`,`username`),
// # Column types:
// # `host_id` int unsigned not null
// # `uid` int unsigned not null
// # `username` varchar(255) collate utf8mb4_unicode_ci not null
// # To remove this duplicate index, execute:
// ALTER TABLE `fleet`.`host_users` DROP INDEX `idx_uid_username`;
//
// # ########################################################################
// # fleet.migration_status_tables
// # ########################################################################
//
// # Uniqueness of id ignored because PRIMARY is a duplicate constraint
// # id is a duplicate of PRIMARY
// # Key definitions:
// # UNIQUE KEY `id` (`id`)
// # PRIMARY KEY (`id`),
// # Column types:
// # `id` bigint unsigned not null auto_increment
// # To remove this duplicate index, execute:
// ALTER TABLE `fleet`.`migration_status_tables` DROP INDEX `id`;
//
// # ########################################################################
// # fleet.policy_membership
// # ########################################################################
//
// # idx_policy_membership_policy_id is a left-prefix of PRIMARY
// # Key definitions:
// # KEY `idx_policy_membership_policy_id` (`policy_id`),
// # PRIMARY KEY (`policy_id`,`host_id`),
// # Column types:
// # `policy_id` int unsigned not null
// # `host_id` int unsigned not null
// # To remove this duplicate index, execute:
// ALTER TABLE `fleet`.`policy_membership` DROP INDEX `idx_policy_membership_policy_id`;
//
// # ########################################################################
// # fleet.software
// # ########################################################################
//
// # Key software_listing_idx ends with a prefix of the clustered index
// # Key definitions:
// # KEY `software_listing_idx` (`name`,`id`),
// # PRIMARY KEY (`id`),
// # Column types:
// # `name` varchar(255) collate utf8mb4_unicode_ci not null
// # `id` bigint unsigned not null auto_increment
// # To shorten this duplicate clustered index, execute:
// ALTER TABLE `fleet`.`software` DROP INDEX `software_listing_idx`, ADD INDEX `software_listing_idx` (`name`);
//
// # ########################################################################
// # fleet.software_cve
// # ########################################################################
//
// # software_cve_software_id is a left-prefix of unq_software_id_cve
// # Key definitions:
// # KEY `software_cve_software_id` (`software_id`)
// # UNIQUE KEY `unq_software_id_cve` (`software_id`,`cve`),
// # Column types:
// # `software_id` bigint unsigned default null
// # `cve` varchar(255) collate utf8mb4_unicode_ci not null
// # To remove this duplicate index, execute:
// ALTER TABLE `fleet`.`software_cve` DROP INDEX `software_cve_software_id`;

_, err := tx.Exec(
"ALTER TABLE `app_config_json` DROP INDEX `id`;" +
"ALTER TABLE `host_users` DROP INDEX `idx_uid_username`;" +
"ALTER TABLE `migration_status_tables` DROP INDEX `id`;" +
"ALTER TABLE `policy_membership` DROP INDEX `idx_policy_membership_policy_id`;" +
"ALTER TABLE `software` DROP INDEX `software_listing_idx`, ADD INDEX `software_listing_idx` (`name`);" +
"ALTER TABLE `software_cve` DROP INDEX `software_cve_software_id`;",
)
if err != nil {
return fmt.Errorf("failed to remove duplicate indexes: %w", err)
}
return nil
}

func Down_20241122171434(tx *sql.Tx) error {
return nil
}
Loading
Loading