Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Add more description to delete host modal #24089

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Nov 22, 2024

Issue

Cerra #23244

Description

  • Add description to delete host modal

Screenshot

Screenshot 2024-11-22 at 2 58 49 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.40%. Comparing base (d80161a) to head (b17d781).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24089      +/-   ##
==========================================
- Coverage   63.40%   63.40%   -0.01%     
==========================================
  Files        1579     1579              
  Lines      150006   150006              
  Branches     3782     3782              
==========================================
- Hits        95112    95110       -2     
- Misses      47310    47312       +2     
  Partials     7584     7584              
Flag Coverage Δ
frontend 52.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RachelElysia RachelElysia marked this pull request as ready for review November 22, 2024 20:55
@RachelElysia RachelElysia requested a review from a team as a code owner November 22, 2024 20:55
Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants