Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teams modal only showing two options (#23889) #24080

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

lukeheath
Copy link
Member

@lukeheath lukeheath commented Nov 22, 2024

For #23888 (cherry pick)

@lukeheath lukeheath requested a review from a team as a code owner November 22, 2024 16:47
@lukeheath lukeheath changed the base branch from main to rc-minor-fleet-v4.60.0 November 22, 2024 16:49
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.15%. Comparing base (f385a8d) to head (98935c0).
Report is 25 commits behind head on rc-minor-fleet-v4.60.0.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           rc-minor-fleet-v4.60.0   #24080      +/-   ##
==========================================================
- Coverage                   63.17%   63.15%   -0.02%     
==========================================================
  Files                        1559     1561       +2     
  Lines                      148191   148301     +110     
  Branches                     3722     3766      +44     
==========================================================
+ Hits                        93617    93665      +48     
- Misses                      47180    47242      +62     
  Partials                     7394     7394              
Flag Coverage Δ
frontend 52.55% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RachelElysia
Copy link
Member

@lukeheath for transparency, we attach both the original PR and the cherry pick PR to the issue in zenhub.

@lukeheath lukeheath merged commit e18729c into rc-minor-fleet-v4.60.0 Nov 22, 2024
11 checks passed
@lukeheath lukeheath deleted the fix-teams-model-cherry branch November 22, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants