Drop Orbit version check on LUKS trigger endpoint #24028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a significant waiting period between upgrading to the newest Orbit and being able to request a key escrow. The tradeoff is that an escrow request would be sent to a client that doesn't support it, then no-op, then need to be sent again.
|
Per discussions, we don't need this. Closing. |
iansltx
deleted the
remove-orbit-version-check-on-luks-trigger-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a significant waiting period between upgrading to the newest Orbit and being able to request a key escrow. The tradeoff is that an escrow request would be sent to a client that doesn't support it, then no-op, then need to be sent again.
Checklist for submitter
- [ ] Manual QA for all new/changed functionalityWill test E2E