Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigiCert certificate management #23994

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

DigiCert certificate management #23994

wants to merge 12 commits into from

Conversation

getvictor
Copy link
Member

#22709

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 28.69718% with 405 lines in your changes missing coverage. Please review.

Project coverage is 63.25%. Comparing base (b1ed70f) to head (57d640d).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
server/service/certificates.go 0.00% 199 Missing ⚠️
server/service/apple_mdm.go 32.15% 138 Missing and 16 partials ⚠️
server/service/appconfig.go 23.33% 21 Missing and 2 partials ⚠️
server/datastore/mysql/certificates.go 70.27% 16 Missing and 6 partials ⚠️
...ations/tables/20241121111624_AddPKICertificates.go 75.00% 4 Missing and 1 partial ⚠️
server/datastore/mysql/hosts.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23994      +/-   ##
==========================================
- Coverage   63.47%   63.25%   -0.22%     
==========================================
  Files        1576     1582       +6     
  Lines      149666   150568     +902     
  Branches     3766     3766              
==========================================
+ Hits        94995    95239     +244     
- Misses      47098    47723     +625     
- Partials     7573     7606      +33     
Flag Coverage Δ
backend 64.10% <28.69%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants