Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portal-impl: fix config ordering #1240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Commits on Jan 2, 2024

  1. portal-impl: fix config ordering

    Quoting portals.conf(5):
    
    > Each key in the group contains a semi-colon separated list of portal backend
    > implementation, to be searched for an implementation of the requested interface,
    > in the same order as specified in the configuration file.
    
    But this wasn't actually true.  If the portals were set to z;y and z
    and y both implemented the same portal, y would be used.
    
    Fixing this requires reworking how portals are selected — going
    through the config file and selecting the first available configured
    portal, rather than going through each known portal and checking
    whether it's allowed in the config file.
    
    find_all_portal_implementations() is unchanged.  The portal-first
    approach is fine for it, and it would be difficult for it to share as
    much code with find_portal_implementation() now that it's written to
    stop as soon as a configured portal is found.
    
    Fixes: flatpak#1111
    alyssais committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    1f423df View commit details
    Browse the repository at this point in the history