Bugfix: jvp now supports alternate mode ordering #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2025
unalmis
reviewed
Aug 20, 2025
There was a problem hiding this comment.
I think this is better handled in the original PR as the tests are there to validate the correctness of the bugfix. I have yet to find the GPU bug, so if you find that, I recommend pushing directly to #159 . Edit: Found and fixed GPU bug as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to Jacobian-vector product implementation to now support alternate mode orderings. This resolves #159 and probably #158.
In #159 the alternate mode ordering (
modord=1) appears to be the sole cause of the dodgy derivatives, becausejvpwas previously hard-coded assuming the default (modeord=0). I modified those tests to use the default and found that they passed to precisionrtol=5e-6, atol=1e-12which is admittedly lower than the default thatnumpyuses. The changes I made here also cause the original versions of the test with alternate mode ordering to pass to the same precision.This is a relatively simple change and I'm happy to format it differently if desired by the maintainers.
Thanks!