Minor fix for apply_shifts and demo.m #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Eftychios, thanks again for the great work!
I find that in apply_shifts, I need an additional line setting up Xq/Yq/Zq when using 'fft'.
Another occasional problem I encountered when using NoRMCorre was that with images that have significant numbers of negative value pixels, the fft registration would produce global phase differences of pi or -pi, and in result, invert the images in terms of pixel intensity. A simple fix to this (I haven't fully explored whether this is a bug or an inevitable result of fft-based registration) is to ensure all pixels are non-negative at start. You had commented this out some time ago, I simply reinstated it. Hope this helps.
Cheers!
-Ingie