Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caiman.base.movies.get_file_size fix #1436

Closed
wants to merge 4 commits into from

Conversation

darikoneil
Copy link
Contributor

Description

Fixes #1431

Fixed inability of caiman.base.movies.get_file_size to handle .npy files. Makes assumption .npy files are a tensor with frames as the first dimension.

Type of change

Bug fix

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Branching

  • All PRs should be made against the dev branch. The main branch is not often merged back to dev.
  • If you want to get your PR out to the world faster (urgent bugfix), poke pgunn to cut a release; this will get it onto github and into conda faster

Has your PR been tested?

If you're fixing a bug or introducing a new feature it is recommended you run the tests by typing

caimanmanager test

and

caimanmanager demotest

prior to submitting your pull request.

Please describe any additional tests that you ran to verify your changes. If they are fast you can also
include them in the folder 'caiman/tests/and name themtest_***.py` so they can be included in our lists of tests.

No additional tests

@darikoneil
Copy link
Contributor Author

Closed, forgot to squash commits. reopening new request, sorry

@darikoneil darikoneil closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant