Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable text-input-v3 support for electron wayland #28

Open
wants to merge 1 commit into
base: zypak
Choose a base branch
from

Conversation

czhang03
Copy link

In the latest version of electron (version 33, chrome M130) the new command line flag will enable text-input-v3 in electron app, allowing the use of IME in DEs that doesn't support the deprecated text-input-v1, including Gnome.

In the latest version of electron (version 33, chrome M130) the new command line flag will enable text-input-v3 in electron app, allowing the use of IME in DEs that doesn't support the deprecated text-input-v1, including Gnome.
@noonsleeper
Copy link
Contributor

@czhang03 I would test this on vscodium-insider

@noonsleeper
Copy link
Contributor

noonsleeper commented Nov 11, 2024

version 33, chrome M130

Well since vscodium is on electron v32 sadly we still need to wait for this.

@czhang03
Copy link
Author

I think it is also good to verify that this change do not break app with electron 32. I don't think it will, but testing is always nice.

@noonsleeper
Copy link
Contributor

@czhang03 you can test it now with
flatpak override --user --env=EDITOR_RUNTIME_ARGS="--wayland-text-input-version=3" com.vscodium.codium-insiders

@czhang03
Copy link
Author

Using this method, when I open vscodium without providing a file or folder, it will open a file named --wayland-text-input-version=3 😂

@noonsleeper
Copy link
Contributor

I tested on F40 and F41, the only thing that happens is this warning on console
Warning: 'wayland-text-input-version' is not in the list of known options, but still passed to Electron/Chromium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants