Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @actions/cache dependency and remove workaround #3

Merged

Conversation

darkdragon-001
Copy link

The linked issue has been fixed upstream. Updating to the version containing the fix and removing the workaround.

@darkdragon-001 darkdragon-001 force-pushed the remove-workaround-cache-path branch from 369dca5 to add6aae Compare March 16, 2024 11:53
@razzeee razzeee requested a review from barthalion March 24, 2024 22:55
@bbhtt
Copy link
Collaborator

bbhtt commented Apr 10, 2024

Please run yarn install for flat-manager before running ncc build ./flat-manager/index.js -o ./flat-manager/dist/, it deleted most of the contents.

@darkdragon-001 darkdragon-001 force-pushed the remove-workaround-cache-path branch from add6aae to 8b8a777 Compare April 11, 2024 18:14
@darkdragon-001 darkdragon-001 force-pushed the remove-workaround-cache-path branch from 8b8a777 to ac1672f Compare April 11, 2024 18:15
@darkdragon-001
Copy link
Author

@bbhtt Oops, I restored the original file.

@darkdragon-001
Copy link
Author

@barthalion @bbhtt could you please take a look? Thanks!

@bbhtt
Copy link
Collaborator

bbhtt commented Jul 29, 2024

Seems fine. Workaround was added in flatpak#149

@bbhtt bbhtt merged commit 9f0ab7b into flathub-infra:master Jul 29, 2024
11 checks passed
@darkdragon-001 darkdragon-001 deleted the remove-workaround-cache-path branch July 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants