forked from rhboot/shim-review
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the Dockerfile for reproducible builds #1
Draft
sayanchowdhury
wants to merge
27
commits into
main
Choose a base branch
from
sayan/add-dockerfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
- Set the SOURCE_DATE_EPOCH in Dockerfile - Checkout to specific tag Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: James Le Cuirot <[email protected]>
Signed-off-by: James Le Cuirot <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
jepio
reviewed
Oct 22, 2024
Signed-off-by: James Le Cuirot <[email protected]>
Signed-off-by: James Le Cuirot <[email protected]>
Signed-off-by: James Le Cuirot <[email protected]>
chewi
force-pushed
the
sayan/add-dockerfile
branch
from
October 22, 2024 21:32
458c591
to
3651e74
Compare
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
t-lo
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
Subject: C=XX, O=MyCompany, Inc., CN=MyCompany, Inc. | ||
``` | ||
|
||
N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets register with the Microsoft Dev Center and fetch this certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(might take a couple of days)
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
jepio
reviewed
Nov 14, 2024
Co-authored-by: Thilo Fromm <[email protected]> Co-authored-by: Jeremi Piotrowski <[email protected]>
Co-authored-by: Jeremi Piotrowski <[email protected]>
It's non-standard. Signed-off-by: James Le Cuirot <[email protected]>
Signed-off-by: James Le Cuirot <[email protected]>
sayanchowdhury
force-pushed
the
sayan/add-dockerfile
branch
from
November 15, 2024 10:12
18c13ec
to
077ae24
Compare
Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.