Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/docker: add devicemapper storage test #474

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Oct 27, 2023

Add a smoke test for the docker devicemapper storage backend.

Flatcar ships docker with support for the devicemapper storage back-end but we don't test it regularly. This has almost lead to the docker 24 update silently shipping without that storage driver.

Fixes flatcar/Flatcar#1222

@t-lo t-lo marked this pull request as ready for review October 27, 2023 16:04
@t-lo t-lo requested a review from a team October 27, 2023 16:04
// This test is normally not related to the cloud environment
Platforms: []string{"qemu", "qemu-unpriv"},
// Note: copied verbatim from https://github.com/coreos/docs/blob/master/os/mounting-storage.md#creating-and-mounting-a-btrfs-volume-file
// Added explicit btrfs driver selection because overlay2 is the default for btrfs FS in docker 23 and above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should rather mention devicemapper, not btrfs2, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct - fixed.

Add a smoke test for the docker devicemapper storage backend.

Flatcar ships docker with support for the devicemapper storage back-end
but we don't test it regularly. This has almost lead to the docker 24
update silently shipping without that storage driver.

Signed-off-by: Thilo Fromm <[email protected]>
@t-lo t-lo force-pushed the t-lo/add-docker-devicemapper-test branch from 469945c to 686a4eb Compare November 1, 2023 08:06
@t-lo t-lo merged commit b8b8303 into flatcar-master Nov 1, 2023
@t-lo t-lo deleted the t-lo/add-docker-devicemapper-test branch November 1, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add kola test for "devicemapper" docker storage driver
2 participants